lkml.org 
[lkml]   [2021]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video
    From
    Hi Hans,

    Please refer to Page 132, 'Video stream data format – ASPEED mode compression' of
    https://github.com/AspeedTech-BMC/openbmc/releases/download/v07.02/SDK_User_Guide_v07.02.pdf

    Is above information enough??
    Or maybe we can postpone this series until the source code for this format ready.
    I think I can accomplish it by the end of this year.

    On 2021/11/25 下午 10:31, Hans Verkuil wrote:
    > Hi Jammy,
    >
    > I suggest posting a v3 that moves the patches that deal with the
    > Aspeed JPEG format to the end of the series. That way I can easily
    > merge the patches up to that point, and the Aspeed JPEG support can
    > be handled separately.
    >
    > I'm not sure if it can be merged without that format being documented,
    > either in pixfmt-reserved.rst, by implementing support for it in
    > libv4lconvert from v4l-utils, or by providing a URL to some other
    > publicly available source code. We really don't like adding pixel
    > formats that cannot be interpreted by someone without access to the
    > datasheets.
    >
    > Regards,
    >
    > Hans
    >
    > On 18/11/2021 08:40, Jammy Huang wrote:
    >> The aim of this series is to add aspeed-jpeg support for aspeed-video
    >> driver.
    >>
    >> To achieve this major goal some refactors are included.
    >>
    >> In the last, debugfs information is also updated per this change.
    >>
    >> Changes in v5:
    >> - Use model data to tell different soc
    >>
    >> Changes in v4:
    >> - Add definition for the Aspeed JPEG format
    >> - Reserve controls for ASPEED
    >> - Use s_fmt to update format rather than new control
    >> - Update aspeed hq quality range, 1 ~ 12
    >>
    >>
    >> Jammy Huang (10):
    >> media: aspeed: move err-handling together to the bottom
    >> media: aspeed: use v4l2_info/v4l2_warn/v4l2_dbg for log
    >> media: aspeed: add more debug log messages
    >> media: aspeed: refactor to gather format/compress settings
    >> media: v4l: Add definition for the Aspeed JPEG format
    >> media: v4l2-ctrls: Reserve controls for ASPEED
    >> media: aspeed: use model-data
    >> media: aspeed: Support aspeed mode to reduce compressed data
    >> media: aspeed: add comments and macro
    >> media: aspeed: Extend debug message
    >>
    >> .../media/uapi/v4l/pixfmt-reserved.rst | 12 +
    >> drivers/media/platform/aspeed-video.c | 534 ++++++++++++++----
    >> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
    >> include/uapi/linux/aspeed-video.h | 15 +
    >> include/uapi/linux/v4l2-controls.h | 5 +
    >> include/uapi/linux/videodev2.h | 1 +
    >> 6 files changed, 467 insertions(+), 101 deletions(-)
    >> create mode 100644 include/uapi/linux/aspeed-video.h
    >>
    --
    Best Regards
    Jammy

    \
     
     \ /
      Last update: 2021-11-26 09:39    [W:2.446 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site