lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 147/251] soc/tegra: Fix an error handling path in tegra_powergate_power_up()
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit 986b5094708e508baa452a23ffe809870934a7df ]

    If an error occurs after a successful tegra_powergate_enable_clocks()
    call, it must be undone by a tegra_powergate_disable_clocks() call, as
    already done in the below and above error handling paths of this function.

    Update the 'goto' to branch at the correct place of the error handling
    path.

    Fixes: a38045121bf4 ("soc/tegra: pmc: Add generic PM domain support")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
    Signed-off-by: Thierry Reding <treding@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/soc/tegra/pmc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
    index 2422ed56895af..71f4ff3e13b46 100644
    --- a/drivers/soc/tegra/pmc.c
    +++ b/drivers/soc/tegra/pmc.c
    @@ -407,7 +407,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,

    err = tegra_powergate_reset_deassert(pg);
    if (err)
    - goto powergate_off;
    + goto disable_clks;

    usleep_range(10, 20);

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:39    [W:3.912 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site