lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 182/207] iavf: Fix for the false positive ASQ/ARQ errors while issuing VF reset
    Date
    From: Surabhi Boob <surabhi.boob@intel.com>

    [ Upstream commit 321421b57a12e933f92b228e0e6d0b2c6541f41d ]

    While issuing VF Reset from the guest OS, the VF driver prints
    logs about critical / Overflow error detection. This is not an
    actual error since the VF_MBX_ARQLEN register is set to all FF's
    for a short period of time and the VF would catch the bits set if
    it was reading the register during that spike of time.
    This patch introduces an additional check to ignore this condition
    since the VF is in reset.

    Fixes: 19b73d8efaa4 ("i40evf: Add additional check for reset")
    Signed-off-by: Surabhi Boob <surabhi.boob@intel.com>
    Tested-by: Tony Brelinski <tony.brelinski@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    index 537776a3e5de1..9ba36425a3ddd 100644
    --- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    +++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
    @@ -1889,7 +1889,7 @@ static void i40evf_adminq_task(struct work_struct *work)

    /* check for error indications */
    val = rd32(hw, hw->aq.arq.len);
    - if (val == 0xdeadbeef) /* indicates device in reset */
    + if (val == 0xdeadbeef || val == 0xffffffff) /* device in reset */
    goto freedom;
    oldval = val;
    if (val & I40E_VF_ARQLEN1_ARQVFE_MASK) {
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 13:28    [W:4.032 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site