lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 154/251] RDMA/mlx4: Return missed an error if device doesnt support steering
    Date
    From: Leon Romanovsky <leonro@nvidia.com>

    [ Upstream commit f4e56ec4452f48b8292dcf0e1c4bdac83506fb8b ]

    The error flow fixed in this patch is not possible because all kernel
    users of create QP interface check that device supports steering before
    set IB_QP_CREATE_NETIF_QP flag.

    Fixes: c1c98501121e ("IB/mlx4: Add support for steerable IB UD QPs")
    Link: https://lore.kernel.org/r/91c61f6e60eb0240f8bbc321fda7a1d2986dd03c.1634023677.git.leonro@nvidia.com
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
    Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/infiniband/hw/mlx4/qp.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
    index df1ecd29057f8..8862eb9a6fe43 100644
    --- a/drivers/infiniband/hw/mlx4/qp.c
    +++ b/drivers/infiniband/hw/mlx4/qp.c
    @@ -1144,8 +1144,10 @@ static int create_qp_common(struct mlx4_ib_dev *dev, struct ib_pd *pd,
    if (dev->steering_support ==
    MLX4_STEERING_MODE_DEVICE_MANAGED)
    qp->flags |= MLX4_IB_QP_NETIF;
    - else
    + else {
    + err = -EINVAL;
    goto err;
    + }
    }

    memcpy(&backup_cap, &init_attr->cap, sizeof(backup_cap));
    --
    2.33.0


    \
     
     \ /
      Last update: 2022-09-17 16:12    [W:4.030 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site