lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V7 05/14] rtla/osnoise: Add the hist mode
On Wed, 24 Nov 2021 17:12:12 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> > + /*
> > + * Set the size of the bucket.
> > + */
> > + bucket_size = params->output_divisor * params->bucket_size;
> > + snprintf(buff, sizeof(buff), "duration.buckets=%d", bucket_size);
> > +
> > + data->trace_hist = tracefs_hist_alloc(tool->trace.tep, "osnoise", "sample_threshold",
> > + buff, TRACEFS_HIST_KEY_NORMAL);
>
> FYI, we changed the API (haven't tagged it yet, so we can do that :-) and
> the above needs to be:
>
> data->trace_hist = tracefs_hist1d_alloc(tool->trace.tep, "osnoise", "sample_threshold",

Or do you think that 1d should be the default, and we have:

tracefs_hist_alloc() -- 1d histogram
tracefs_hist_alloc_2d() -- 2d histogram
tracefs_hist_alloc_nd() -- Nd histogram?

??

We haven't tagged it yet, so we could change it again (and then your code
will work as is).

-- Steve

\
 
 \ /
  Last update: 2021-11-24 23:16    [W:0.184 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site