lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 167/279] i40e: Fix display error code in dmesg
    Date
    From: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>

    [ Upstream commit 5aff430d4e33a0b48a6b3d5beb06f79da23f9916 ]

    Fix misleading display error in dmesg if tc filter return fail.
    Only i40e status error code should be converted to string, not linux
    error code. Otherwise, we return false information about the error.

    Fixes: 2f4b411a3d67 ("i40e: Enable cloud filters via tc-flower")
    Signed-off-by: Grzegorz Szczurek <grzegorzx.szczurek@intel.com>
    Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
    Tested-by: Dave Switzer <david.switzer@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/intel/i40e/i40e_main.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
    index 83413999902e5..76d0b809d1340 100644
    --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
    +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
    @@ -8531,9 +8531,8 @@ static int i40e_configure_clsflower(struct i40e_vsi *vsi,
    err = i40e_add_del_cloud_filter(vsi, filter, true);

    if (err) {
    - dev_err(&pf->pdev->dev,
    - "Failed to add cloud filter, err %s\n",
    - i40e_stat_str(&pf->hw, err));
    + dev_err(&pf->pdev->dev, "Failed to add cloud filter, err %d\n",
    + err);
    goto err;
    }

    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 15:44    [W:4.041 / U:0.240 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site