lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 214/279] ata: libata: add missing ata_identify_page_supported() calls
    Date
    From: Damien Le Moal <damien.lemoal@opensource.wdc.com>

    commit 06f6c4c6c3e8354dceddd77bd58f9a7a84c67246 upstream.

    ata_dev_config_ncq_prio() and ata_dev_config_devslp() both access pages
    of the IDENTIFY DEVICE data log. Before calling ata_read_log_page(),
    make sure to check for the existence of the IDENTIFY DEVICE data log and
    of the log page accessed using ata_identify_page_supported(). This
    avoids useless error messages from ata_read_log_page() and failures with
    some LLDD scsi drivers using libsas.

    Reported-by: Nikolay <knv418@gmail.com>
    Cc: stable@kernel.org # 5.15
    Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
    Tested-by: Matthew Perkowski <mgperkow@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/ata/libata-core.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/ata/libata-core.c
    +++ b/drivers/ata/libata-core.c
    @@ -2167,6 +2167,9 @@ static void ata_dev_config_ncq_prio(stru
    struct ata_port *ap = dev->link->ap;
    unsigned int err_mask;

    + if (!ata_identify_page_supported(dev, ATA_LOG_SATA_SETTINGS))
    + return;
    +
    err_mask = ata_read_log_page(dev,
    ATA_LOG_IDENTIFY_DEVICE,
    ATA_LOG_SATA_SETTINGS,
    @@ -2443,7 +2446,8 @@ static void ata_dev_config_devslp(struct
    * Check device sleep capability. Get DevSlp timing variables
    * from SATA Settings page of Identify Device Data Log.
    */
    - if (!ata_id_has_devslp(dev->id))
    + if (!ata_id_has_devslp(dev->id) ||
    + !ata_identify_page_supported(dev, ATA_LOG_SATA_SETTINGS))
    return;

    err_mask = ata_read_log_page(dev,

    \
     
     \ /
      Last update: 2021-11-24 15:03    [W:5.796 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site