lkml.org 
[lkml]   [2021]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 048/154] sh: check return code of request_irq
    Date
    From: Nick Desaulniers <ndesaulniers@google.com>

    [ Upstream commit 0e38225c92c7964482a8bb6b3e37fde4319e965c ]

    request_irq is marked __must_check, but the call in shx3_prepare_cpus
    has a void return type, so it can't propagate failure to the caller.
    Follow cues from hexagon and just print an error.

    Fixes: c7936b9abcf5 ("sh: smp: Hook in to the generic IPI handler for SH-X3 SMP.")
    Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
    Cc: Paul Mundt <lethal@linux-sh.org>
    Reported-by: Guenter Roeck <linux@roeck-us.net>
    Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
    Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
    Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
    Signed-off-by: Rich Felker <dalias@libc.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/sh/kernel/cpu/sh4a/smp-shx3.c | 5 +++--
    1 file changed, 3 insertions(+), 2 deletions(-)

    diff --git a/arch/sh/kernel/cpu/sh4a/smp-shx3.c b/arch/sh/kernel/cpu/sh4a/smp-shx3.c
    index f8a2bec0f260b..1261dc7b84e8b 100644
    --- a/arch/sh/kernel/cpu/sh4a/smp-shx3.c
    +++ b/arch/sh/kernel/cpu/sh4a/smp-shx3.c
    @@ -73,8 +73,9 @@ static void shx3_prepare_cpus(unsigned int max_cpus)
    BUILD_BUG_ON(SMP_MSG_NR >= 8);

    for (i = 0; i < SMP_MSG_NR; i++)
    - request_irq(104 + i, ipi_interrupt_handler,
    - IRQF_PERCPU, "IPI", (void *)(long)i);
    + if (request_irq(104 + i, ipi_interrupt_handler,
    + IRQF_PERCPU, "IPI", (void *)(long)i))
    + pr_err("Failed to request irq %d\n", i);

    for (i = 0; i < max_cpus; i++)
    set_cpu_present(i, true);
    --
    2.33.0


    \
     
     \ /
      Last update: 2021-11-24 14:31    [W:2.418 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site