Messages in this thread | | | Date | Tue, 23 Nov 2021 14:03:13 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH V2] tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown() |
| |
On Tue, Nov 23, 2021 at 06:51:22PM +0800, Sherry Sun wrote: > From: Fugang Duan <fugang.duan@nxp.com> > > Disable the UCR4_OREN bit in .stop_rx() before the uart receiver is disabled > maybe better than in the .shutdown() function.
There should be a better incentive than "maybe it's better to do this". My expectation is that you verify there is indeed an issue and then fix that with a descriptive commit log that convinces this is indeed a fix.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |