lkml.org 
[lkml]   [2021]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH -next] ipmi: msghandler: Make symbol 'remove_work_wq' static
On Tue, Nov 23, 2021 at 08:36:18AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/char/ipmi/ipmi_msghandler.c:194:25: warning:
> symbol 'remove_work_wq' was not declared. Should it be static?
>
> This symbol is not used outside of ipmi_msghandler.c, so
> marks it static.

Thanks, I should have noticed this.

-corey

>
> Fixes: 1d49eb91e86e ("ipmi: Move remove_work to dedicated workqueue")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/char/ipmi/ipmi_msghandler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 1ade72bfae0f..a2ec0171363a 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -191,7 +191,7 @@ struct ipmi_user {
> struct work_struct remove_work;
> };
>
> -struct workqueue_struct *remove_work_wq;
> +static struct workqueue_struct *remove_work_wq;
>
> static struct ipmi_user *acquire_ipmi_user(struct ipmi_user *user, int *index)
> __acquires(user->release_barrier)
>

\
 
 \ /
  Last update: 2021-11-23 13:46    [W:0.048 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site