Messages in this thread Patch in this message | | | Date | Mon, 22 Nov 2021 08:14:25 -0800 | From | Colin Foster <> | Subject | Re: [PATCH v1 net-next 5/6] net: mscc: ocelot: split register definitions to a separate file |
| |
On Sun, Nov 21, 2021 at 05:09:39PM +0000, Vladimir Oltean wrote: > On Fri, Nov 19, 2021 at 02:43:12PM -0800, Colin Foster wrote: > > Move these to a separate file will allow them to be shared to other > > drivers. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > --- > ... > > -static const u32 ocelot_ana_regmap[] = { > ... > > +const u32 vsc7514_ana_regmap[] = { > ... > > diff --git a/include/soc/mscc/vsc7514_regs.h b/include/soc/mscc/vsc7514_regs.h > > new file mode 100644 > > index 000000000000..c39f64079a0f > > --- /dev/null > > +++ b/include/soc/mscc/vsc7514_regs.h > > @@ -0,0 +1,27 @@ > > +/* SPDX-License-Identifier: (GPL-2.0 OR MIT) */ > > +/* > > + * Microsemi Ocelot Switch driver > > + * > > + * Copyright (c) 2021 Innovative Advantage Inc. > > + */ > > + > > +#ifndef VSC7514_REGS_H > > +#define VSC7514_REGS_H > > + > > +extern const u32 ocelot_ana_regmap[]; > > +extern const u32 ocelot_qs_regmap[]; > > +extern const u32 ocelot_qsys_regmap[]; > > +extern const u32 ocelot_rew_regmap[]; > > +extern const u32 ocelot_sys_regmap[]; > > +extern const u32 ocelot_vcap_regmap[]; > > +extern const u32 ocelot_ptp_regmap[]; > > +extern const u32 ocelot_dev_gmii_regmap[]; > I have a vague impression that you forgot to rename these.
I think you're right. I'll include this in v2.
> > > + > > +extern const struct vcap_field vsc7514_vcap_es0_keys[]; > > +extern const struct vcap_field vsc7514_vcap_es0_actions[]; > > +extern const struct vcap_field vsc7514_vcap_is1_keys[]; > > +extern const struct vcap_field vsc7514_vcap_is1_actions[]; > > +extern const struct vcap_field vsc7514_vcap_is2_keys[]; > > +extern const struct vcap_field vsc7514_vcap_is2_actions[]; > > + > > +#endif > > -- > > 2.25.1 > >
| |