lkml.org 
[lkml]   [2021]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] regulator: lp87565: Use bitfield helpers
    Date
    Use the FIELD_PREP() helper, instead open-coding the same operation.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    ---
    Compile-tested only.

    See "[PATCH 00/17] Non-const bitfield helper conversions"
    (https://lore.kernel.org/r/cover.1637592133.git.geert+renesas@glider.be)
    for background and more conversions.
    ---
    drivers/regulator/lp87565-regulator.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
    index d059ae85047a0815..db95dcbc3dedfab6 100644
    --- a/drivers/regulator/lp87565-regulator.c
    +++ b/drivers/regulator/lp87565-regulator.c
    @@ -5,6 +5,7 @@
    * Copyright (C) 2017 Texas Instruments Incorporated - https://www.ti.com/
    */

    +#include <linux/bitfield.h>
    #include <linux/module.h>
    #include <linux/platform_device.h>
    #include <linux/regmap.h>
    @@ -99,7 +100,7 @@ static int lp87565_buck_set_ramp_delay(struct regulator_dev *rdev,

    ret = regmap_update_bits(rdev->regmap, regulators[id].ctrl2_reg,
    LP87565_BUCK_CTRL_2_SLEW_RATE,
    - reg << __ffs(LP87565_BUCK_CTRL_2_SLEW_RATE));
    + FIELD_PREP(LP87565_BUCK_CTRL_2_SLEW_RATE, reg));
    if (ret) {
    dev_err(&rdev->dev, "SLEW RATE write failed: %d\n", ret);
    return ret;
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-11-22 16:55    [W:4.968 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site