lkml.org 
[lkml]   [2021]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/4] regulators: irq_helper: Provide helper for trivial IRQ notifications
Date
On 11/22/21 13:48, Andy Shevchenko wrote:
> On Mon, Nov 22, 2021 at 01:04:12PM +0200, Matti Vaittinen wrote:
>> Provide a generic map_event helper for regulators which have a notification
>> IRQ with single, well defined purpose. Eg, IRQ always indicates exactly one
>> event for exactly one regulator device. For such IRQs the mapping is
>> trivial.
>
> ...
>
>> + int err = rid->states[0].possible_errs;
>
> I would rather make it unsigned, but anyway...
>
>> + !single_bit_set(err, sizeof(err) * 8)))
>
> hweight32() seems suitable here.

Thanks Andy,

I\ll see how it works out and respin. I agree this use/case probably
does not warrant adding the single_bit_set().

Best Regards
-- Matti Vaittinen


--
The Linux Kernel guy at ROHM Semiconductors

Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~ this year is the year of a signature writers block ~~
\
 
 \ /
  Last update: 2021-11-22 13:46    [W:1.264 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site