Messages in this thread | | | Subject | Re: [PATCH] media: rockchip/rga: do proper error checking in probe | From | Kieran Bingham <> | Date | Mon, 22 Nov 2021 12:32:48 +0000 |
| |
Quoting Kyle Copperfield (2021-11-20 12:23:02) > The latest fix for probe error handling contained a typo that causes > probing to fail with the following message: > > rockchip-rga: probe of ff680000.rga failed with error -12 > > This patch fixes the typo. > > Fixes: e58430e1d4fd (media: rockchip/rga: fix error handling in probe) > Reviewed-by: Dragan Simic <dragan.simic@gmail.com> > Signed-off-by: Kyle Copperfield <kmcopper@danwin1210.me> > --- > drivers/media/platform/rockchip/rga/rga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index 6759091b15e0..d99ea8973b67 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -895,7 +895,7 @@ static int rga_probe(struct platform_device *pdev) > } > rga->dst_mmu_pages = > (unsigned int *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, 3); > - if (rga->dst_mmu_pages) { > + if (!rga->dst_mmu_pages) {
Ouch, that indeed looks like it was unhelpful..
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ret = -ENOMEM; > goto free_src_pages; > } > -- > 2.34.0 >
| |