Messages in this thread | | | Date | Mon, 22 Nov 2021 11:52:50 +0000 | From | Sudeep Holla <> | Subject | Re: [PATCH 1/1] firmware: smccc: Fix check for ARCH_SOC_ID not implemented |
| |
On Mon, Nov 22, 2021 at 11:56:16AM +0100, Arnd Bergmann wrote: > On Mon, Nov 22, 2021 at 9:35 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Nov 19, 2021 at 03:39:01PM -0800, Michael Kelley wrote: > > > The ARCH_FEATURES function ID is a 32-bit SMC call, which returns > > > a 32-bit result per the SMCCC spec. Current code is doing a 64-bit > > > comparison against -1 (SMCCC_RET_NOT_SUPPORTED) to detect that the > > > feature is unimplemented. That check doesn't work in a Hyper-V VM, > > > where the upper 32-bits are zero as allowed by the spec. > > > > > > Cast the result as an 'int' so the comparison works. The change also > > > makes the code consistent with other similar checks in this file. > > > > > > Fixes: 821b67fa4639 ("firmware: smccc: Add ARCH_SOC_ID support") > > > > Good catch. > > > > Reviewed-by: Sudeep Holla <sudeep.holla@arm.com> > > > > Can you please re-post with my review tag keeping arm@kernel.org and > > soc@kernel.org ? I don't have any other fixes at the moment, we can > > ask SoC maintainers to fix this up directly. > > In general, I think the easiest way would be for you to forward the > patch with your Signed-off-by, when you don't have other material > for a pull request. >
Thanks for the tip, I will follow that in future.
> I've applied this patch from the list now. >
Thanks for that.
-- Regards, Sudeep
| |