lkml.org 
[lkml]   [2021]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2 16/20] linux/compiler.h, linux/array_size.h: Move __must_be_array() into <linux/array_size.h>
    On Sat, Nov 20, 2021 at 2:01 PM Alejandro Colomar
    <alx.manpages@gmail.com> wrote:
    >
    > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>

    Each patch should describe why you move this, it's not clear what the
    benefit is here.

    > diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h
    > index 7a5925072466..f6fc1c72dfa7 100644
    > --- a/drivers/gpu/drm/i915/i915_utils.h
    > +++ b/drivers/gpu/drm/i915/i915_utils.h
    > @@ -25,6 +25,8 @@
    > #ifndef __I915_UTILS_H
    > #define __I915_UTILS_H
    >
    > +
    > +#include <linux/array_size.h>

    Avoid adding the extra whitespace here.

    Arnd

    \
     
     \ /
      Last update: 2021-11-21 14:25    [W:3.663 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site