lkml.org 
[lkml]   [2021]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 5/9] mfd: max77714: Add driver for Maxim MAX77714 PMIC
From
On 20/11/2021 16:57, Luca Ceresoli wrote:
> Add a simple driver for the Maxim MAX77714 PMIC, supporting RTC and
> watchdog only.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> ---
>
> Changes in v4: none
>
> Changes in v3:
> - Suggested by Lee Jones:
> - move struct mfd_cell to top of file
> - remove struct max77714 and its kmalloc, not used after probe
> - reword error messages
> - add "/* pF */" onto the end of the load_cap line
>
> Changes in v2:
> - fix "watchdog" word in heading comment (Guenter Roeck)
> - move struct max77714 to .c file (Krzysztof Kozlowski)
> - change include guard format (Krzysztof Kozlowski)
> - allow building as a module (Krzysztof Kozlowski)
> - remove of_match_ptr usage (Krzysztof Kozlowski / lkp)
> (Reported-by: kernel test robot <lkp@intel.com>)
> ---
> MAINTAINERS | 2 +
> drivers/mfd/Kconfig | 14 ++++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/max77714.c | 152 +++++++++++++++++++++++++++++++++++
> include/linux/mfd/max77714.h | 60 ++++++++++++++
> 5 files changed, 229 insertions(+)
> create mode 100644 drivers/mfd/max77714.c
> create mode 100644 include/linux/mfd/max77714.h
>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2021-11-21 18:21    [W:0.099 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site