Messages in this thread | | | Date | Sat, 20 Nov 2021 13:23:24 -0800 | From | Colin Foster <> | Subject | Re: [PATCH v1 net-next 1/3] net: mdio: mscc-miim: convert to a regmap implementation |
| |
Hi Jakub,
Kernel Test Robot caught this as well. I'll fix in v2. Thanks for the feedback!
On Fri, Nov 19, 2021 at 07:56:10PM -0800, Jakub Kicinski wrote: > On Fri, 19 Nov 2021 13:39:16 -0800 Colin Foster wrote: > > Utilize regmap instead of __iomem to perform indirect mdio access. This > > will allow for custom regmaps to be used by way of the mscc_miim_setup > > function. > > > > Signed-off-by: Colin Foster <colin.foster@in-advantage.com> > > clang says: > > drivers/net/mdio/mdio-mscc-miim.c:228:30: warning: variable 'bus' is uninitialized when used here [-Wuninitialized] > mscc_miim_setup(&pdev->dev, bus, mii_regmap, phy_regmap); > > drivers/net/mdio/mdio-mscc-miim.c:216:13: warning: variable 'dev' is uninitialized when used here [-Wuninitialized] > if (IS_ERR(dev->phy_regs)) { > ^~~
| |