Messages in this thread | | | Date | Tue, 2 Nov 2021 11:35:52 -0500 | Subject | Re: [PATCH] pinctrl: qcom: sdm845: Enable dual edge errata | From | Steev Klimaszewski <> |
| |
On 11/1/21 10:41 PM, Bjorn Andersson wrote: > It has been observed that dual edge triggered wakeirq GPIOs on SDM845 > doesn't trigger interrupts on the falling edge. > > Enabling wakeirq_dual_edge_errata for SDM845 indicates that the PDC in > SDM845 suffers from the same problem described, and worked around, by > Doug in 'c3c0c2e18d94 ("pinctrl: qcom: Handle broken/missing PDC dual > edge IRQs on sc7180")', so enable the workaround for SDM845 as well. > > The specific problem seen without this is that gpio-keys does not detect > the falling edge of the LID gpio on the Lenovo Yoga C630 and as such > consistently reports the LID as closed. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > drivers/pinctrl/qcom/pinctrl-sdm845.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sdm845.c b/drivers/pinctrl/qcom/pinctrl-sdm845.c > index c51793f6546f..fdfd7b8f3a76 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sdm845.c > +++ b/drivers/pinctrl/qcom/pinctrl-sdm845.c > @@ -1310,6 +1310,7 @@ static const struct msm_pinctrl_soc_data sdm845_pinctrl = { > .ngpios = 151, > .wakeirq_map = sdm845_pdc_map, > .nwakeirq_map = ARRAY_SIZE(sdm845_pdc_map), > + .wakeirq_dual_edge_errata = true, > }; > > static const struct msm_pinctrl_soc_data sdm845_acpi_pinctrl = {
Tested here with a number of suspend cycles, works as expected now. Thank you so much!
Tested-By: Steev Klimaszewski <steev@kali.org>
| |