Messages in this thread | | | Date | Tue, 2 Nov 2021 16:02:45 +0300 | From | Dan Carpenter <> | Subject | Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe |
| |
On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote: > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > index 366161cff560..7206d29ba263 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c > @@ -1715,6 +1715,12 @@ void atomisp_wdt_refresh_pipe(struct atomisp_video_pipe *pipe, > { > unsigned long next; > > + if(!pipe->asd) {
Run your patches through scripts/checkpatch.pl.
> + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n", > + __func__, pipe->vdev.name); > + return; > + }
regards, dan carpenter
| |