Messages in this thread | | | Date | Tue, 2 Nov 2021 11:35:38 +0000 | From | Lee Jones <> | Subject | Re: [PATCH] mfd: simple-mfd-i2c: Select MFD_CORE to fix build error |
| |
On Tue, 02 Nov 2021, Robert Marko wrote:
> On Tue, Nov 2, 2021 at 12:17 PM Lee Jones <lee.jones@linaro.org> wrote: > > > > On Tue, 02 Nov 2021, Robert Marko wrote: > > > > > MFD_SIMPLE_MFD_I2C should select the MFD_CORE to a prevent build error: > > > > > > aarch64-linux-ld: drivers/mfd/simple-mfd-i2c.o: in function `simple_mfd_i2c_probe': > > > drivers/mfd/simple-mfd-i2c.c:55: undefined reference to `devm_mfd_add_devices' > > > > What is your use-case? > > > > How are you enabling this symbol? > > Hi Lee, > I am adding a symbol like MFD_SL28CPLD does that you can depend on and > that simply > selects the MFD_SIMPLE_MFD_I2C and I have hit this issue since the > MFD_CORE is not selected.
That's interesting.
I wonder how MFD_SL28CPLD selects it?
> > > Fixes: 3abee4579484 ("mfd: Add simple regmap based I2C driver") > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > > --- > > > drivers/mfd/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 61992edf6a4d..2de69892b631 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -1204,6 +1204,7 @@ config MFD_SI476X_CORE > > > config MFD_SIMPLE_MFD_I2C > > > tristate > > > depends on I2C > > > + select MFD_CORE > > > select REGMAP_I2C > > > help > > > This driver creates a single register map with the intention for it > > > > >
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |