Messages in this thread | | | Date | Tue, 2 Nov 2021 11:17:26 +0100 | Subject | Re: [PATCH v2 07/12] watchdog: s3c2410: Implement a way to invert mask reg value | From | Krzysztof Kozlowski <> |
| |
On 31/10/2021 13:22, Sam Protsenko wrote: > On new Exynos chips (like Exynos850) the MASK_WDT_RESET_REQUEST register > is replaced with CLUSTERx_NONCPU_INT_EN, and its mask bit value meaning > was reversed: for new register the bit value "1" means "Interrupt > enabled", while for MASK_WDT_RESET_REQUEST register "1" means "Mask the > interrupt" (i.e. "Interrupt disabled"). > > Introduce "mask_reset_inv" boolean field in driver data structure; when > that field is "true", mask register handling function will invert the > value before setting it to the register. > > This commit doesn't bring any functional change to existing devices, but > merely provides an infrastructure for upcoming chips support. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > --- > Changes in v2: > - (none): it's a new patch > > drivers/watchdog/s3c2410_wdt.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards, Krzysztof
| |