lkml.org 
[lkml]   [2021]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/13] arm: Kconfig.debug: drop reference to removed ARCH_MSM
On Thu, Oct 28, 2021 at 4:42 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> >
> > Commit c0c89fafa289 ("ARM: Remove mach-msm and associated ARM architecture
> > code") removes the definition of the config ARCH_MSM. Since then, the
> > reference to ARCH_MSM in the dependencies of UNCOMPRESS_INCLUDE in
> > Kconfig.debug is dead.
> >
> > Fortunately, ./scripts/checkkconfigsymbols.py warns:
> >
> > ARCH_MSM
> > Referencing files: arch/arm/Kconfig.debug
> >
> > Drop the dependency on this removed config.
> >
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > arch/arm/Kconfig.debug | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 83484564b1d9..87aa6e92ee6e 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -1886,7 +1886,7 @@ config DEBUG_UNCOMPRESS
> >
> > config UNCOMPRESS_INCLUDE
> > string
> > - default "debug/uncompress.h" if ARCH_MULTIPLATFORM || ARCH_MSM || \
> > + default "debug/uncompress.h" if ARCH_MULTIPLATFORM || \
> > PLAT_SAMSUNG || ARM_SINGLE_ARMV7M
>
> The PLAT_SAMSUNG reference is also misplaced here, I think you just want
> ARCH_S3C24XX instead, since the other samsung ones already require
> ARCH_MULTIPLATFORM.
>

Agree. I can clean up (or better stated: optimize) the dependencies
further in such a way. But that config dependency optimization goes
beyond just removing dead symbols and deserves to be its own patch.
Patch will follow later this week.

Lukas

\
 
 \ /
  Last update: 2021-11-02 08:55    [W:0.050 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site