Messages in this thread | | | Subject | Re: ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! | From | Randy Dunlap <> | Date | Fri, 19 Nov 2021 07:41:26 -0800 |
| |
On 11/18/21 10:26 PM, Sergio Paracuellos wrote: > Hi Randy, > > On Fri, Nov 19, 2021 at 5:56 AM Randy Dunlap <rdunlap@infradead.org> wrote: >> >> On 11/17/21 11:09 AM, kernel test robot wrote: >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>> head: ee1703cda8dc777e937dec172da55beaf1a74919 >>> commit: 2bdd5238e756aac3ecbffc7c22b884485e84062e PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver >>> date: 4 weeks ago >>> config: mips-allmodconfig (attached as .config) >>> compiler: mips-linux-gcc (GCC) 11.2.0 >>> reproduce (this is a W=1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2bdd5238e756aac3ecbffc7c22b884485e84062e >>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >>> git fetch --no-tags linus master >>> git checkout 2bdd5238e756aac3ecbffc7c22b884485e84062e >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=mips >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot <lkp@intel.com> >>> >>> All errors (new ones prefixed by >>, old ones prefixed by <<): >>> >>> ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o >>>>> ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! >>>>> ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! >>>>> ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! >>>>> ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! >>>>> ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! >> >> >> This is one way to fix these build errors. Is that what the MIPS people >> want to do or should their be APIs to access these base addresses and >> mips_cm_is64 data? > > A similar patch was already sent a few weeks ago and Thomas asked for > a different approach [0]. > I have sent a patch series removing mips stuff from the driver > controller. This series has not been reviewed yet [1]. > > [0]: https://lore.kernel.org/linux-mips/CAMhs-H8ShoaYiFOOzJaGC68nZz=V365RXN_Kjuj=fPFENGJiiw@mail.gmail.com/T/#t > [1]: https://marc.info/?l=linux-pci&m=163696011110084&w=3 >
Oh, very good then. Thanks.
-- ~Randy
| |