lkml.org 
[lkml]   [2021]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: arm: apple: Add iMac (24-inch 2021) to Apple bindings
> From: Janne Grunau <j@jannau.net>
> Date: Tue, 16 Nov 2021 22:53:14 +0100
>
> This introduces compatible strings for both 2021 Apple iMac M1 devices:
>
> * apple,j456 - iMac (24-inch, 4x USB-C, M1, 2021)
> * apple,j457 - iMac (24-inch, 2x USB-C, M1, 2021)
>
> Signed-off-by: Janne Grunau <j@jannau.net>
> ---
> Documentation/devicetree/bindings/arm/apple.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Minor nit below. Maybe not even worth respinning this series for.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> diff --git a/Documentation/devicetree/bindings/arm/apple.yaml b/Documentation/devicetree/bindings/arm/apple.yaml
> index 1e772c85206c..1416ed3a5623 100644
> --- a/Documentation/devicetree/bindings/arm/apple.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple.yaml
> @@ -12,12 +12,12 @@ maintainers:
> description: |
> ARM platforms using SoCs designed by Apple Inc., branded "Apple Silicon".
>
> - This currently includes devices based on the "M1" SoC, starting with the
> - three Mac models released in late 2020:
> + This currently includes devices based on the "M1" SoC:
>
> - Mac mini (M1, 2020)
> - MacBook Pro (13-inch, M1, 2020)
> - MacBook Air (M1, 2020)
> + - iMac (24-inch 2021)

iMac (24-inch, M1, 2021)

> The compatible property should follow this format:
>
> @@ -56,6 +56,8 @@ properties:
> - apple,j274 # Mac mini (M1, 2020)
> - apple,j293 # MacBook Pro (13-inch, M1, 2020)
> - apple,j313 # MacBook Air (M1, 2020)
> + - apple,j456 # iMac (24-inch, 4x USB-C, M1, 2021)
> + - apple,j457 # iMac (24-inch, 2x USB-C, M1, 2021)
> - const: apple,t8103
> - const: apple,arm-platform
>
> --
> 2.33.1
>
>

\
 
 \ /
  Last update: 2021-11-19 12:22    [W:0.196 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site