Messages in this thread | | | Subject | Re: [PATCH v1 2/3] x86/quirks: Introduce hpet_dev_print_force_hpet_address() helper | From | Joe Perches <> | Date | Fri, 19 Nov 2021 03:20:09 -0800 |
| |
On Fri, 2021-11-19 at 13:00 +0200, Andy Shevchenko wrote: > Introduce hpet_dev_print_force_hpet_address() helper to unify printing > forced HPET address. No functional change intended.
This probably reduces object code by a few bytes of text.
> diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c [] > @@ -68,6 +68,11 @@ static enum { > ATI_FORCE_HPET_RESUME, > } force_hpet_resume_type; > > +static void hpet_dev_print_force_hpet_address(struct device *dev) > +{ > + dev_printk(KERN_DEBUG, dev, "Force enabled HPET at 0x%lx\n", force_hpet_address); > +}
And this might be better placed up a few lines immediately after
unsigned long force_hpet_address;
and before
enum { ... } force_hpet_resume_type;
| |