Messages in this thread | | | Date | Fri, 19 Nov 2021 09:18:06 +0100 | From | Miquel Raynal <> | Subject | Re: [PATCH v2 1/4] mtd: rawnand: Fix nand_erase_op delay |
| |
Hi Herve,
herve.codina@bootlin.com wrote on Fri, 19 Nov 2021 08:39:06 +0100:
> NAND_OP_CMD() expect a delay parameter in nanoseconds.
expects
> The delay value is wrongly given in milliseconds. > > Fix the conversion macro used in order to set this > delay in nanoseconds. >
I believe you still miss the Fixes: tag here :)
> Signed-off-by: Herve Codina <herve.codina@bootlin.com> > --- > Changes v1 -> v2: > - Commit log reword > > drivers/mtd/nand/raw/nand_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index 3d6c6e880520..5c6b065837ef 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -1837,7 +1837,7 @@ int nand_erase_op(struct nand_chip *chip, unsigned int eraseblock) > NAND_OP_CMD(NAND_CMD_ERASE1, 0), > NAND_OP_ADDR(2, addrs, 0), > NAND_OP_CMD(NAND_CMD_ERASE2, > - NAND_COMMON_TIMING_MS(conf, tWB_max)), > + NAND_COMMON_TIMING_NS(conf, tWB_max)), > NAND_OP_WAIT_RDY(NAND_COMMON_TIMING_MS(conf, tBERS_max), > 0), > };
Thanks, Miquèl
| |