Messages in this thread | | | Date | Thu, 18 Nov 2021 18:09:37 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] net: bnx2x: fix variable dereferenced before check |
| |
On Thu, Nov 18, 2021 at 09:51:57AM +0100, Johan Hovold wrote: > [ Adding Dan. ] > > On Sun, Nov 14, 2021 at 01:36:36AM +0300, Pavel Skripkin wrote: > > Smatch says: > > bnx2x_init_ops.h:640 bnx2x_ilt_client_mem_op() > > warn: variable dereferenced before check 'ilt' (see line 638) > > > > Move ilt_cli variable initialization _after_ ilt validation, because > > it's unsafe to deref the pointer before validation check. > > It seems smatch is confused here. There is no dereference happening > until after the check, we're just determining the address when > initialising ilt_cli.
Yep. You're right. I will fix this. I've written a fix and I'll test it tonight.
regards, dan carpenter
| |