lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021
Date
Dear greg k-h:

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, November 17, 2021 4:53 PM
> To: Tony Huang <tonyhuang.sunplus@gmail.com>
> Cc: robh+dt@kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; derek.kiernan@xilinx.com;
> dragan.cvetic@xilinx.com; arnd@arndb.de; Wells Lu 呂芳騰
> <wells.lu@sunplus.com>; Tony Huang 黃懷厚 <tony.huang@sunplus.com>
> Subject: Re: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021
>
> On Wed, Nov 17, 2021 at 02:48:07PM +0800, Tony Huang wrote:
> > Add iop driver for Sunplus SP7021
> >
> > Signed-off-by: Tony Huang <tony.huang@sunplus.com>
>
> Along with everything that Arnd said, one more thing:
>
> > +#define IOP_KDBG_INFO
> > +#define IOP_FUNC_DEBUG
> > +#define IOP_KDBG_ERR
> > +#ifdef IOP_KDBG_INFO
> > + #define FUNC_DEBUG() pr_info("K_IOP: %s(%d)\n", __func__, __LINE__)
> > +#else
> > + #define FUNC_DEBUG()
> > +#endif
>
> This should just be deleted entirely, use ftrace if you want to see what your
> kernel driver is doing.

OK, I will delete it.

>
> No single driver should have special debugging macros like this, use the
> kernel-wide system please.
>
> This driver code can get a lot smaller after you make these cleanups.
> Also be sure to use scripts/checkpatch.pl to remove the issues that it points out
> so we don't have to say the same thing.
>
> thanks,
>
> greg k-h
\
 
 \ /
  Last update: 2021-11-17 10:17    [W:0.068 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site