lkml.org 
[lkml]   [2021]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] perf/test: Test case 27 broken on s390 in linux-next
From

On 11/3/21 21:22, Thomas Richter wrote:
> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
>
> # ./perf test -Fv 27
> 27: Sample parsing
> --- start ---
> parsing failed for sample_type 0x800
> ---- end ----
> Sample parsing: FAILED!
> #
>
> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
> in above commit. Correct this define and the test case runs fine.
>
> Output After:
> # ./perf test -Fv 27
> 27: Sample parsing :
> --- start ---
> ---- end ----
> Sample parsing: Ok
> #


Hi Thomas,
Thanks for the fix. Not sure, I guess I messed up my big endian setup or
test run I had before sending
the patch. My bad. It fails for me too, but with your patch the issue
fixed.

Acked-and-Tested-by: Madhavan Srinivasan <maddy@linux.ibm.com>


>
> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
> Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
> ---
> tools/perf/tests/sample-parsing.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
> index c83a11514129..9c7af55b74db 100644
> --- a/tools/perf/tests/sample-parsing.c
> +++ b/tools/perf/tests/sample-parsing.c
> @@ -36,7 +36,7 @@
> * These are based on the input value (213) specified
> * in branch_stack variable.
> */
> -#define BS_EXPECTED_BE 0xa00d000000000000
> +#define BS_EXPECTED_BE 0xa000d00000000000
> #define BS_EXPECTED_LE 0xd5000000
> #define FLAG(s) s->branch_stack->entries[i].flags
>

\
 
 \ /
  Last update: 2021-11-17 10:07    [W:0.442 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site