lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging: r8188eu: remove unused defines in wifi.h
From
On 11/16/21 04:14, Zameer Manji wrote:
> None of these defines in wifi.h are used so they
> can be safely removed.
>
> Signed-off-by: Zameer Manji <zmanji@gmail.com>
> ---
> drivers/staging/r8188eu/include/wifi.h | 57 --------------------------
> 1 file changed, 57 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/include/wifi.h b/drivers/staging/r8188eu/include/wifi.h
> index 193a557f0f47..7cbc7015e90f 100644
> --- a/drivers/staging/r8188eu/include/wifi.h
> +++ b/drivers/staging/r8188eu/include/wifi.h
> @@ -13,32 +13,9 @@
> #define BIT(x) (1 << (x))

What about BIT() macro? It's already defined in include/vdso/bits.h and
can be included via include/bits.h.

Most likely linux/ieee80211.h contains bits.h. Haven't checked yet, but
anyway redefining kernel macros is not good approach and BIT() can be
also removed.



With regards,
Pavel Skripkin

\
 
 \ /
  Last update: 2021-11-16 06:51    [W:0.033 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site