lkml.org 
[lkml]   [2021]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] mlx5: fix mlx5i_grp_sw_update_stats() stack usage
Date
On Mon, 2021-11-08 at 12:10 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The mlx5e_sw_stats structure has grown to the point of triggering
> a warning when put on the stack of a function:
>
> mlx5/core/ipoib/ipoib.c: In function 'mlx5i_grp_sw_update_stats':
> mlx5/core/ipoib/ipoib.c:136:1: error: the frame size of 1028 bytes is
> larger than 1024 bytes [-Werror=frame-larger-than=]
>
> In this case, only five of the structure members are actually set,
> so it's sufficient to have those as separate local variables.
> As en_rep.c uses 'struct rtnl_link_stats64' for this, just use
> the same one here for consistency.
>
> Fixes: def09e7bbc3d ("net/mlx5e: Add HW_GRO statistics")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks Arnd, Both patches applied to net-next-mlx5,

Since I will be queuing them up for net-next, I will have to remove the
Fixes tags.


\
 
 \ /
  Last update: 2021-11-16 21:52    [W:0.053 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site