Messages in this thread | | | Date | Mon, 15 Nov 2021 16:22:01 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood |
| |
On Mon, Nov 15, 2021 at 01:43:02PM +0200, Jani Nikula wrote: > On Mon, 15 Nov 2021, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Oct 05, 2021 at 02:34:23PM -0700, Lucas De Marchi wrote: > >> On Mon, Feb 15, 2021 at 04:21:35PM +0200, Andy Shevchenko wrote: > >> > We have already few similar implementation and a lot of code that can benefit > >> > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > >> > >> I was taking a look on i915_utils.h to reduce it and move some of it > >> elsewhere to be shared with others. I was starting with these helpers > >> and had [1] done, then Jani pointed me to this thread and also his > >> previous tentative. I thought the natural place for this would be > >> include/linux/string_helpers.h, but I will leave it up to you. > > > > Seems reasonable to use string_helpers (headers and/or C-file). > > > >> After reading the threads, I don't see real opposition to it. > >> Is there a tree you plan to take this through? > > > > I rest my series in favour of Jani's approach, so I suppose there is no go > > for _this_ series. > > If you want to make it happen, please pick it up and drive it. I'm > thoroughly had enough of this.
My point is still the same, so it's more to Lucas.
I'm not going to drive this activity due to lack of time.
> >> [1] https://lore.kernel.org/lkml/20211005212634.3223113-1-lucas.demarchi@intel.com/T/#u
-- With Best Regards, Andy Shevchenko
| |