lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/11] iommu: Add device dma ownership set/release interfaces
From
Date
Hi Christoph,

On 11/15/21 9:14 PM, Christoph Hellwig wrote:
> On Mon, Nov 15, 2021 at 10:05:42AM +0800, Lu Baolu wrote:
>> +enum iommu_dma_owner {
>> + DMA_OWNER_NONE,
>> + DMA_OWNER_KERNEL,
>> + DMA_OWNER_USER,
>> +};
>> +
>
>> + enum iommu_dma_owner dma_owner;
>> + refcount_t owner_cnt;
>> + struct file *owner_user_file;
>
> I'd just overload the ownership into owner_user_file,
>
> NULL -> no owner
> (struct file *)1UL) -> kernel
> real pointer -> user
>
> Which could simplify a lot of the code dealing with the owner.
>

Yeah! Sounds reasonable. I will make this in the next version.

Best regards,
baolu

\
 
 \ /
  Last update: 2021-11-16 03:08    [W:0.392 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site