lkml.org 
[lkml]   [2021]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/11] dmaengine: pxa/mmp: stop referencing config->slave_id
    Date
    From: Arnd Bergmann <arnd@arndb.de>

    The last driver referencing the slave_id on Marvell PXA and MMP platforms
    was the SPI driver, but this stopped doing so a long time ago, so the
    TODO from the earlier patch can no be removed.

    Fixes: b729bf34535e ("spi/pxa2xx: Don't use slave_id of dma_slave_config")
    Fixes: 13b3006b8ebd ("dma: mmp_pdma: add filter function")
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/dma/mmp_pdma.c | 6 ------
    drivers/dma/pxa_dma.c | 7 -------
    2 files changed, 13 deletions(-)

    diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
    index a23563cd118b..5a53d7fcef01 100644
    --- a/drivers/dma/mmp_pdma.c
    +++ b/drivers/dma/mmp_pdma.c
    @@ -727,12 +727,6 @@ static int mmp_pdma_config_write(struct dma_chan *dchan,

    chan->dir = direction;
    chan->dev_addr = addr;
    - /* FIXME: drivers should be ported over to use the filter
    - * function. Once that's done, the following two lines can
    - * be removed.
    - */
    - if (cfg->slave_id)
    - chan->drcmr = cfg->slave_id;

    return 0;
    }
    diff --git a/drivers/dma/pxa_dma.c b/drivers/dma/pxa_dma.c
    index 52d04641e361..6078cc81892e 100644
    --- a/drivers/dma/pxa_dma.c
    +++ b/drivers/dma/pxa_dma.c
    @@ -909,13 +909,6 @@ static void pxad_get_config(struct pxad_chan *chan,
    *dcmd |= PXA_DCMD_BURST16;
    else if (maxburst == 32)
    *dcmd |= PXA_DCMD_BURST32;
    -
    - /* FIXME: drivers should be ported over to use the filter
    - * function. Once that's done, the following two lines can
    - * be removed.
    - */
    - if (chan->cfg.slave_id)
    - chan->drcmr = chan->cfg.slave_id;
    }

    static struct dma_async_tx_descriptor *
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-11-15 09:58    [W:6.145 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site