lkml.org 
[lkml]   [2021]   [Nov]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC PATCH v3 5/7] gpio: gpiolib: Add ngirq member to struct gpio_irq_chip
On Thu, Nov 11, 2021 at 12:59 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
>
> Number of GPIO IRQ's supported by the chip is not always

supported GPIO IRQs by the chip

> equal to the number of GPIO pins. For example on Renesas RZ/G2L
> SoC where it has GPIO0-122 pins but at a give point a maximum
> of only 32 GPIO pins can be used as IRQ lines in the IRQC domain.
>
> This patch adds ngirq member to struct gpio_irq_chip and passes
> this as a size to irq_domain_create_hierarchy()/irq_domain_create_simple()
> if it is being set in the driver otherwise fallbacks to using ngpio.

...

> gc->irq.domain = irq_domain_create_hierarchy(
> gc->irq.parent_domain,
> 0,
> - gc->ngpio,
> + gc->irq.ngirq ? gc->irq.ngirq : gc->ngpio,

You may use ?: instead as it's done somewhere else in this module.

> gc->irq.fwnode,
> &gc->irq.child_irq_domain_ops,
> gc);

...

> gc->irq.domain = irq_domain_create_simple(fwnode,
> - gc->ngpio,
> + gc->irq.ngirq ? gc->irq.ngirq : gc->ngpio,

Ditto.

> gc->irq.first,
> gc->irq.domain_ops ?: &gpiochip_domain_ops,

(^^^ You see?)

> gc);

...

> + /**
> + * @ngirq:
> + *
> + * The number of GPIO IRQ's handled by this IRQ domain; usually is

handled GPIO IRQs

> + * equal to ngpio

Missed period.

> + */

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-11-11 21:53    [W:0.263 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site