lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v4 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper
On Mon, Nov 1, 2021 at 12:44 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Nov 1, 2021 at 12:31 PM Hans de Goede <hdegoede@redhat.com> wrote:
> > On 10/25/21 13:31, Andy Shevchenko wrote:
> > > On Mon, Oct 25, 2021 at 12:42 PM Hans de Goede <hdegoede@redhat.com> wrote:

...

> > >> + if (ret == 0 && sensor_adev_ret)
> > >> + *sensor_adev_ret = sensor;
> > >> + else
> > >> + acpi_dev_put(sensor);
> > >> +
> > >> + return ret;

...

> > > if (sensor_adev_ret)
> > > *sensor_adev_ret = sensor;
> > >
> > > return 0;
> > >
> > > ?
> >
> > That misses an acpi_dev_put(sensor) when sensor_adev_ret == NULL.
>
> else
> acpi_dev_put(...);
>
> ?

Hmm... But then in the original code and with this proposal the
acpi_dev_put() seems a bit strange to me.
If we are fine (no error code returned) why would the caller (note
_er_) go different paths?

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-11-01 11:48    [W:0.086 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site