Messages in this thread | | | Subject | Re: [PATCH v1 1/4] coresight: etm4x: Add lock for reading virtual context ID comparator | From | Suzuki K Poulose <> | Date | Mon, 1 Nov 2021 09:49:06 +0000 |
| |
Hi Leo
On 31/10/2021 14:42, Leo Yan wrote: > When read the virtual context ID comparator value via sysfs node, the > driver firstly reads out the index, then reads the comparator value > based on index. > > This patch adds the spinlock to protect the atomicity for up two steps.
minor nit: This could be :
"Updates to the values and the index are protected via the spinlock. Ensure we use the same lock to read the value safely"
With that:
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
| |