lkml.org 
[lkml]   [2021]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.14 091/125] net/tls: Fix flipped sign in async_wait.err assignment
    Date
    From: Daniel Jordan <daniel.m.jordan@oracle.com>

    commit 1d9d6fd21ad4a28b16ed9ee5432ae738b9dc58aa upstream.

    sk->sk_err contains a positive number, yet async_wait.err wants the
    opposite. Fix the missed sign flip, which Jakub caught by inspection.

    Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance")
    Suggested-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Daniel Jordan <daniel.m.jordan@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/tls/tls_sw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/tls/tls_sw.c
    +++ b/net/tls/tls_sw.c
    @@ -459,7 +459,7 @@ static void tls_encrypt_done(struct cryp

    /* If err is already set on socket, return the same code */
    if (sk->sk_err) {
    - ctx->async_wait.err = sk->sk_err;
    + ctx->async_wait.err = -sk->sk_err;
    } else {
    ctx->async_wait.err = err;
    tls_err_abort(sk, err);

    \
     
     \ /
      Last update: 2021-11-01 10:49    [W:4.515 / U:0.660 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site