lkml.org 
[lkml]   [2021]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in scsi_transport_iscsi.c
I will send a V2 patch.

----- 原始邮件 -----
发件人: "Joe Perches" <joe@perches.com>
收件人: "Guo Zhi" <qtxuning1999@sjtu.edu.cn>, "Lee Duncan" <lduncan@suse.com>, "Chris Leech" <cleech@redhat.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>
抄送: open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, "linux-kernel" <linux-kernel@vger.kernel.org>
发送时间: 星期六, 2021年 10 月 09日 上午 11:14:36
主题: Re: [PATCH] scsi scsi_transport_iscsi.c: fix misuse of %llu in scsi_transport_iscsi.c

On Sat, 2021-10-09 at 11:02 +0800, Guo Zhi wrote:
> Pointers should be printed with %p or %px rather than
> cast to (unsigned long long) and printed with %llu.
> Change %llu to %p to print the pointer into sysfs.
][]
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
[]
> @@ -129,8 +129,8 @@ show_transport_handle(struct device *dev, struct device_attribute *attr,
>  
>
>   if (!capable(CAP_SYS_ADMIN))
>   return -EACCES;
> - return sysfs_emit(buf, "%llu\n",
> - (unsigned long long)iscsi_handle(priv->iscsi_transport));
> + return sysfs_emit(buf, "%p\n",
> + iscsi_ptr(priv->iscsi_transport));

iscsi_transport is a pointer isn't it?

so why not just

return sysfs_emit(buf, "%p\n", priv->iscsi_transport);

?

\
 
 \ /
  Last update: 2021-10-09 06:36    [W:1.169 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site