Messages in this thread | | | From | Oskar Senft <> | Date | Sat, 9 Oct 2021 23:26:53 -0400 | Subject | Re: [PATCH v5 2/2] hwmon: (nct7802) Make temperature/voltage sensors configurable |
| |
Hi Guenter
Thanks again for the review!
> > + bool found_channel_config = false; > > now unused, as 0-day points out. Argh, I'm so sorry. I don't understand why building this for OpenBMC didn't flag that up. I thought building with warnings as errors was now the default? But obviously not :-/
> > + /* Enable local temperature sensor by default */ > > + mode_val |= MODE_LTD_EN; > > + mode_mask |= MODE_LTD_EN; > > + > > Either make it = and drop the initialization above, or better > initialize the variables with MODE_LTD_EN right away. Oh yeah, makes sense. Will do in V6.
Thanks Oskar.
| |