Messages in this thread | | | Date | Sat, 9 Oct 2021 19:24:45 +0200 | From | Andrew Lunn <> | Subject | Re: [net-next PATCH v2 15/15] dt-bindings: net: dsa: qca8k: document support for qca8328 |
| |
On Fri, Oct 08, 2021 at 02:22:25AM +0200, Ansuel Smith wrote: > QCA8328 is the birrget brother of 8327. Document the new compatible
birrget?
> binding. > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com> > --- > Documentation/devicetree/bindings/net/dsa/qca8k.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > index 9fb4db65907e..0e84500b8db2 100644 > --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt > +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt > @@ -3,6 +3,7 @@ > Required properties: > > - compatible: should be one of: > + "qca,qca8328" > "qca,qca8327" > "qca,qca8334" > "qca,qca8337"
This is much nice than the old DT property. But since the internal IDs are the same, i think it would be good to add a little documentation here about how the 8327 and 8328 differ, since most people are not going to look at the commit message.
Andrew
| |