Messages in this thread | | | Date | Fri, 8 Oct 2021 15:44:27 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf report: Output non-zero offset for decompressed records |
| |
Em Mon, Oct 04, 2021 at 09:06:36AM +0200, Jiri Olsa escreveu: > On Mon, Oct 04, 2021 at 10:00:52AM +0300, Bayduraev, Alexey V wrote: > > On 04.10.2021 9:42, Jiri Olsa wrote: > > > On Wed, Sep 29, 2021 at 12:14:45PM +0300, Alexey Bayduraev wrote: > > >> Print offset of PERF_RECORD_COMPRESSED record instead of zero for > > >> decompressed records in raw trace dump (-D option of perf-report):
> > >> 0x17cf08 [0x28]: event: 9
> > >> instead of:
> > >> 0 [0x28]: event: 9
> > >> The fix is not critical, because currently file_pos for compressed > > >> events is used in perf_session__process_event only to show offsets > > >> in the raw dump.
> > > I don't mind the change just curious, because I see also: > > > > > > perf_session__process_event > > > perf_session__process_user_event > > > lseek(fd, file_offset, ...
> > > which is not raw dump as the comment suggests
> > Yes, but this "lseek" only works for user events, whereas the > > PERF_RECORD_COMPRESSED record shouln't contain such events. > > Currently, the PERF_RECORD_COMPRESSED container can only pack > > kernel events.
> Acked-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied.
- Arnaldo
| |