lkml.org 
[lkml]   [2021]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Re: [PATCH] x86/microcode/amd: Add __list_del_entry_valid() in front of __list_del() in free_cache()
Date
On Tue, Sep 28, 2021 at 22:29:19PM +0000, Christoph Hellwig wrote:
>On Tue, Sep 28, 2021 at 09:04:44AM +0000, Jiasheng Jiang wrote:
>> Directly use __list_del() to remove 'p->plist' might be unsafe,
>> as we can see from the __list_del_entry_valid() of 'lib/list_debug.c'
>> that p->plist->prev or p->plist->next may be the LIST_POISON,
>> or p->list is not a valid double list.
>> In that case, __list_del() will be corruption.
>> Therefore, we suggest that __list_del_entry_valid()
>> should be added in front of the __list_del() in free_cache.

>No one should be using list_del directly anyway, so please fix that.

What the 'fix that' means?

\
 
 \ /
  Last update: 2021-10-08 09:13    [W:0.048 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site