lkml.org 
[lkml]   [2021]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/9] iio: adc: lpc18xx_adc: Make use of the helper function dev_err_probe()
    Date
    When possible use dev_err_probe help to properly deal with the
    PROBE_DEFER error, the benefit is that DEFER issue will be logged
    in the devices_deferred debugfs file.
    Using dev_err_probe() can reduce code size, and the error value
    gets printed.

    Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
    ---
    v1->v2: Remove the separate line of PTR_ERR().

    drivers/iio/adc/lpc18xx_adc.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/drivers/iio/adc/lpc18xx_adc.c b/drivers/iio/adc/lpc18xx_adc.c
    index 3566990ae87d..440bf28e0605 100644
    --- a/drivers/iio/adc/lpc18xx_adc.c
    +++ b/drivers/iio/adc/lpc18xx_adc.c
    @@ -137,19 +137,17 @@ static int lpc18xx_adc_probe(struct platform_device *pdev)
    return PTR_ERR(adc->base);

    adc->clk = devm_clk_get(&pdev->dev, NULL);
    - if (IS_ERR(adc->clk)) {
    - dev_err(&pdev->dev, "error getting clock\n");
    - return PTR_ERR(adc->clk);
    - }
    + if (IS_ERR(adc->clk))
    + return dev_err_probe(&pdev->dev, PTR_ERR(adc->clk),
    + "error getting clock\n");

    rate = clk_get_rate(adc->clk);
    clkdiv = DIV_ROUND_UP(rate, LPC18XX_ADC_CLK_TARGET);

    adc->vref = devm_regulator_get(&pdev->dev, "vref");
    - if (IS_ERR(adc->vref)) {
    - dev_err(&pdev->dev, "error getting regulator\n");
    - return PTR_ERR(adc->vref);
    - }
    + if (IS_ERR(adc->vref))
    + return dev_err_probe(&pdev->dev, PTR_ERR(adc->vref),
    + "error getting regulator\n");

    indio_dev->name = dev_name(&pdev->dev);
    indio_dev->info = &lpc18xx_adc_info;
    --
    2.25.1
    \
     
     \ /
      Last update: 2021-10-08 11:30    [W:3.425 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site