lkml.org 
[lkml]   [2021]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] opp: Fix return in _opp_add_static_v2()
On 08-10-21, 15:46, YueHaibing wrote:
> Fix sparse warning:
> drivers/opp/of.c:924 _opp_add_static_v2() warn: passing zero to 'ERR_PTR'
>
> For duplicate OPPs 'ret' be set to zero.
>
> Fixes: deac8703da5f ("PM / OPP: _of_add_opp_table_v2(): increment count only if OPP is added")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/opp/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 2a97c6535c4c..c32ae7497392 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -921,7 +921,7 @@ static struct dev_pm_opp *_opp_add_static_v2(struct opp_table *opp_table,
> free_opp:
> _opp_free(new_opp);
>
> - return ERR_PTR(ret);
> + return ret ? ERR_PTR(ret) : NULL;
> }
>
> /* Initializes OPP tables based on new bindings */

Applied. Thanks.

--
viresh

\
 
 \ /
  Last update: 2021-10-08 10:05    [W:0.050 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site