lkml.org 
[lkml]   [2021]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v5 06/10] ovl: implement overlayfs' ->write_inode operation
 ---- 在 星期四, 2021-10-07 22:46:46 Jan Kara <jack@suse.cz> 撰写 ----
> On Thu 07-10-21 15:34:19, Miklos Szeredi wrote:
> > On Thu, 7 Oct 2021 at 15:10, Chengguang Xu <cgxu519@mykernel.net> wrote:
> > > > However that wasn't what I was asking about. AFAICS ->write_inode()
> > > > won't start write back for dirty pages. Maybe I'm missing something,
> > > > but there it looks as if nothing will actually trigger writeback for
> > > > dirty pages in upper inode.
> > > >
> > >
> > > Actually, page writeback on upper inode will be triggered by overlayfs ->writepages and
> > > overlayfs' ->writepages will be called by vfs writeback function (i.e writeback_sb_inodes).
> >
> > Right.
> >
> > But wouldn't it be simpler to do this from ->write_inode()?
>
> You could but then you'd have to make sure you have I_DIRTY_SYNC always set
> when I_DIRTY_PAGES is set on the upper inode so that your ->write_inode()
> callback gets called. Overall I agree the logic would be probably simpler.
>

Hi Jan, Miklos

Thnaks for your suggestions. Let me have a try in next version.


Thanks,
Chengguang

\
 
 \ /
  Last update: 2021-10-07 16:54    [W:0.265 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site