Messages in this thread Patch in this message | | | Date | Thu, 7 Oct 2021 07:52:16 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2 2/4] fs/exec: use strscpy instead of strlcpy in __set_task_comm |
| |
On Thu, Oct 07, 2021 at 12:07:50PM +0000, Yafang Shao wrote: > Fix a warning by checkpatch - > WARNING: Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > > Signed-off-by: Yafang Shao <laoar.shao@gmail.com> > Cc: Kees Cook <keescook@chromium.org> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Petr Mladek <pmladek@suse.com>
Acked-by: Kees Cook <keescook@chromium.org>
> --- > fs/exec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/exec.c b/fs/exec.c > index a098c133d8d7..de804c566200 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -1224,7 +1224,7 @@ void __set_task_comm(struct task_struct *tsk, const char *buf, bool exec) > { > task_lock(tsk); > trace_task_rename(tsk, buf); > - strlcpy(tsk->comm, buf, sizeof(tsk->comm)); > + strscpy(tsk->comm, buf, sizeof(tsk->comm)); > task_unlock(tsk); > perf_event_comm(tsk, exec); > } > -- > 2.18.2 >
-- Kees Cook
| |