lkml.org 
[lkml]   [2021]   [Oct]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 11/11] media: dt-bindings: Convert Cadence CSI2RX binding to YAML
On 07/10/21 02:54AM, Laurent Pinchart wrote:
> Hi Pratyush,
>
> Thank you for the patch.
>
> On Wed, Sep 15, 2021 at 05:32:40PM +0530, Pratyush Yadav wrote:
[...]
> > + ports:
> > + $ref: /schemas/graph.yaml#/properties/ports
> > +
> > + properties:
> > + port@0:
> > + $ref: /schemas/graph.yaml#/$defs/port-base
> > + unevaluatedProperties: false
> > + description: CSI-2 input
> > +
> > + properties:
> > + endpoint:
> > + $ref: video-interfaces.yaml#
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + clock-lanes:
> > + maxItems: 1
> > +
> > + data-lanes:
> > + minItems: 1
> > + maxItems: 4
> > + items:
> > + maximum: 4
> > +
> > + required:
> > + - clock-lanes
> > + - data-lanes
> > +
> > + port@1:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Stream 0 output
> > +
> > + port@2:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Stream 1 output
> > +
> > + port@3:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Stream 2 output
> > +
> > + port@4:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: Stream 3 output
> > +
> > + required:
> > + - port@0
> > +
> > +
> > +dependencies:
> > + phys: [ 'phy-names' ]
> > + phy-names: [ 'phys' ]
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
>
> Shouldn't "ports" be required too ?

Yes, it should be. Will fix. Thanks.

>
> With those comments addressed,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

--
Regards,
Pratyush Yadav
Texas Instruments Inc.

\
 
 \ /
  Last update: 2021-10-07 14:19    [W:0.518 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site