lkml.org 
[lkml]   [2021]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board
On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote:
> Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board

Not super helpful, what does 'update' mean?

It might be easier to have a single patch for both IDP boards, since
the Bluetooth node is added in the common sc7280-idp.dtsi board,
rather than explaining what this patch does :)

> This patch updates bluetooth node in SC7280 IDP2 board.
>
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> index 1fc2add..5c8d54b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> @@ -15,9 +15,15 @@
>
> aliases {
> serial0 = &uart5;
> + bluetooth0 = &bluetooth;
> + hsuart0 = &uart7;
> };

Sort aliases alphabetically

>
> chosen {
> stdout-path = "serial0:115200n8";
> };
> };
> +
> +&bluetooth: wcn6750-bt {

&bluetooth {

> + vddio-supply = <&vreg_l18b_1p8>;

nit: if it's not really common across IDP boards or a default, you could
leave it unconfigured in sc7280-idp.dtsi, and set in both board files.
Just an idea, with only two boards it doesn't really matter too much.

\
 
 \ /
  Last update: 2021-10-06 19:40    [W:1.117 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site